Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline prop in FormRow has no effect #414

Open
haobo-chen opened this issue Jun 8, 2018 · 2 comments
Open

Inline prop in FormRow has no effect #414

haobo-chen opened this issue Jun 8, 2018 · 2 comments

Comments

@haobo-chen
Copy link
Contributor

haobo-chen commented Jun 8, 2018

inline prop in FormRow is dereferenced but not used or passed to any child component

@gthomas-appfolio
Copy link
Contributor

Thanks for the catch 👍

@joshuasbates
Copy link
Contributor

I noted this in a recent change to FormRow (#426):

// Note:  `inline` has no effect at the moment.  In reactstrap 5 and later, this property appears
// to be relevant for the <FormGroup>, though.  As such, we may be able to simplify this class with
// the built-in support of inline forms in newer versions of reactstrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants