Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AePageObjects::Collection specifies 'exact: true' when query #188

Open
JingyuZ opened this issue Sep 15, 2016 · 2 comments
Open

AePageObjects::Collection specifies 'exact: true' when query #188

JingyuZ opened this issue Sep 15, 2016 · 2 comments

Comments

@JingyuZ
Copy link
Contributor

JingyuZ commented Sep 15, 2016

We didn't specify exact: true at any other places except for Collection class. For all the others they just use the default value for Capybara setting, which is false. https://github.com/appfolio/ae_page_objects/blob/master/lib/ae_page_objects/elements/collection.rb#L71

We are not sure why Collection is the exceptional one that has to specify exact: true. Any reasons behind it? If not, could we remove it and use the default value?

@JingyuZ JingyuZ changed the title AePageObjects::Collection specifies exact: true when query AePageObjects::Collection specifies 'exact: true' when query Sep 15, 2016
@ipmsteven
Copy link
Contributor

Hi @JingyuZ
Does this cause problem in running test? could you give more context?

@JingyuZ
Copy link
Contributor Author

JingyuZ commented Sep 15, 2016

I created the issue not because I want to remove exact: true from collection right now, it’s more like a question for Donnie why we are only being strict with collections, why don't we set exact: true in Capybara settings and make everything strict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants