-
Notifications
You must be signed in to change notification settings - Fork 146
GOARCH is '386' and not 'i386' #571
Comments
Sigh, this is an unfortunate side effect of 41fc66c and is probably going to bite us with other combinations too. Any bright ideas here, aside from aliasing a bunch of combinations? /cc @mpasternacki |
Well, I actually built 32-bit I see the issue just as a typo - Go compiler developers call 32-bit 386, and you i386. Is it deeper? |
Sort of - check out some historical discussion here. We are not strictly using Go's concepts for these values (at the very least since the spec should be language-agnostic) I am not really sure what to do here aside from removing the whitelist entirely. |
The removal of the whitelist looks good. The architecture is commonly called However, Well, most of my thoughts have already been discussed in the issue mentioned by you. |
Apparently
runtime.GOARCH
value is put into image metadata when building images (it's"386"
on 32-bit x86 systems):https://github.com/appc/spec/blob/master/ace/build_aci#L25
However, during validation
"i386"
is used (with an extrai
):https://github.com/appc/spec/blob/master/schema/types/labels.go#L24
The text was updated successfully, but these errors were encountered: