Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set label:false as default #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

smathy
Copy link

@smathy smathy commented Aug 12, 2015

Nice and simple :)

@apotonick
Copy link
Owner

Whoohoo! ❤️

@smathy
Copy link
Author

smathy commented Aug 12, 2015

You can put placeholders into the locale files so you don't have to specify that in the HAML either, you want that too?

@apotonick
Copy link
Owner

Awesome, please!!!!

@smathy
Copy link
Author

smathy commented Aug 12, 2015

💥

@apotonick
Copy link
Owner

I merged this into chapter-10 but now explicitly defined labels don't work anymore, for example in app/views/things/new.html.haml the

= f.input :is_author, as: :boolean, label: "I'm the author!"

doesn't render the label anymore?!?!?!

@smathy
Copy link
Author

smathy commented Aug 23, 2015

Might need to give a special wrapper that renders labels for those cases. I'm away until Wednesday, but I'll take a look then.

@smathy
Copy link
Author

smathy commented Aug 26, 2015

I tried checking out chapter-10 but got a bunch of errors relating to Trailblazer::Operation::Policy - maybe something you didn't commit/push?

@apotonick
Copy link
Owner

Oh sorry, yeah, I am still referencing my local trailblazer gem and the policy branch. I will merge it into master today. Thanks for your help! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants