Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have rover dev watch for subgraph add/delete in config option #1885

Open
michael-watson opened this issue Apr 8, 2024 · 0 comments
Open
Labels
feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged

Comments

@michael-watson
Copy link
Contributor

Description

rover dev can currently uses the --supergraph-config option to point at a supergraph config file (docs). But if you add or remove a subgraph from the config while working in it, rover dev doesn't update as expected.

If a subgraph is added to the --supergraph-config during a rover dev session, no subgraph is added to the current rover dev session.

If a subgraph is deleted from the --supergraph-config during a rover dev session, the subgraph still exists in the current rover dev session.

Workaround

Restart rover dev:

  • Kill process
  • Rerun same terminal command

Use Cases

  • Apollo Workbench 😁 - If a session is active and someone adds a subgraph, it would be nice to have this hot-reload handled in rover. I currently workaround this by stopping and restarting the dev session which is fine for smaller graphs, but maybe untenable for larger graphs with hundreds of subgraphs.
@michael-watson michael-watson added feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged labels Apr 8, 2024
michael-watson added a commit to apollographql/apollo-workbench-vscode that referenced this issue Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant