Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kakarot: add kkrt logo overlay to connector icons #536

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

parzuko
Copy link

@parzuko parzuko commented Nov 25, 2024

📖 description

this PR aims to add a kkrt logo overlay to injected connector icons
also, fixes #534

📷 photo demos

image

🐛 type of change

  • New feature (non-breaking change which adds functionality)

🏁 checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@parzuko parzuko requested a review from fracek as a code owner November 25, 2024 10:32
@Eikix
Copy link
Contributor

Eikix commented Nov 26, 2024

Can you modify the demo page to display wallet logos?

This is currently what demo/accounts page looks like with this PR. It'd be nice to display logos to be able to verify it works as intended.

image

How to reproduce?
1/ Checkout this PR
2/ run pnpm run dev
3/ go to localhost / demo / account

PS: Bonus point for fixing the flex box for the demo page, it's a bit ugly:P

@parzuko
Copy link
Author

parzuko commented Nov 26, 2024

@Eikix take a look now 👇

image

also, i think build is failing because of an error within the workflow file 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants