Change `exit()` to `sys.exit()` #339

tofu-rocketry · 2024-05-21T09:55:22Z

The exit() function is from site.py which may not be present depending on command line options. sys.exit on the other hand, will be there as it is imported.

The "exit()" function is from site.py which may not be present depending on command line options. "sys.exit" on the other hand, will be there as it is imported.

norealroots

Looks good to me, happy to approve.

tofu-rocketry added the bug label May 21, 2024

tofu-rocketry added this to the 3.4.1 milestone May 21, 2024

tofu-rocketry self-assigned this May 21, 2024

tofu-rocketry requested a review from a team as a code owner May 21, 2024 09:55

Change exit() to sys.exit()

aff1392

The "exit()" function is from site.py which may not be present depending on command line options. "sys.exit" on the other hand, will be there as it is imported.

tofu-rocketry force-pushed the sys-exit branch from 91f3c7c to aff1392 Compare May 21, 2024 09:59

norealroots approved these changes May 21, 2024

View reviewed changes

tofu-rocketry merged commit 6f008a2 into apel:dev May 21, 2024
10 of 12 checks passed

tofu-rocketry deleted the sys-exit branch May 21, 2024 15:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change `exit()` to `sys.exit()` #339

Change `exit()` to `sys.exit()` #339

tofu-rocketry commented May 21, 2024

norealroots left a comment

Change exit() to sys.exit() #339

Change exit() to sys.exit() #339

Conversation

tofu-rocketry commented May 21, 2024

norealroots left a comment

Choose a reason for hiding this comment

Change `exit()` to `sys.exit()` #339

Change `exit()` to `sys.exit()` #339