Remove LDAP that was deprecated last commit

[RedProkofiev]

Resolves #225
Resolves GT-215

Goodbye, LDAP. Hello, new world! This pull request cleanly exorcises LDAP from our codebase, leaving the only mark of its passing the mention of a BDII in the setup/config files.

[gregcorbett]

I assume this means we can now remove LDAP as a requirement from these places:

• setup.py
• requirements.txt
• apel-ssm.spec

[RedProkofiev]

Yes, that should be correct. I'll get rid of them, next.

[RedProkofiev]

Anything I've missed?

[tofu-rocketry]

The [broker] section of the two configs could do with tidying up.

[gregcorbett]

What happens at https://github.com/apel/ssm/pull/265/files#diff-24d78e07bee2eb3c5108ab36194eba3f8765c8c6b86da792ac2b1a87447dc4b6L180-L184 now that brokers isn't set in the Ssm2.STOMP_MESSAGING case?

Does the SSM just refuse to run because brokers is None so has length 0?

@tofu-rocketry, does this change negate apel/apel#40 ?

[RedProkofiev]

try:
    host = cp.get('broker', 'host')
    port = cp.get('broker', 'port')
    brokers = [(host, int(port))]
except ConfigParser.NoOptionError:
    ...
    sys.exit(1)

I may be missing something but I don't think there's a non exiting case in stomp SSL where brokers will ever be 0 if host and port has been set correctly

[gregcorbett]

try:
    host = cp.get('broker', 'host')
    port = cp.get('broker', 'port')
    brokers = [(host, int(port))]
except ConfigParser.NoOptionError:
    ...
    sys.exit(1)

I may be missing something but I don't think there's a non exiting case in stomp SSL where brokers will ever be 0 if host and port has been set correctly

Yes, you're right - I'm being silly.

[tofu-rocketry]

All that beautiful code lost, like tears in rain. 🥲

[RedProkofiev]

Just went through the requested changes: everything was done though I needed to add back the changelog tag

[tofu-rocketry]

Bit about installing LDAP in the README needs removing.

[RedProkofiev]

my first PR to this repository, ready! a PR to destroy so much LDAP! my eyes are getting misty :,)

[tofu-rocketry]

my first PR to this repository, ready! a PR to destroy so much LDAP! my eyes are getting misty :,)

Thanks for doing that fix! I wasn't expecting you to do it personally.

[RedProkofiev]

One less headache, aye? ship it!

…

On Thu, 9 May 2024, 14:04 Adrian Coveney, ***@***.***> wrote: my first PR to this repository, ready! a PR to destroy so much LDAP! my eyes are getting misty :,) Thanks for doing that fix! I wasn't expecting you to do it personally. — Reply to this email directly, view it on GitHub <#265 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AU3PGZ4YBQUAMOQ3YVX64XLZBNX65AVCNFSM6AAAAAA442N5UWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBSGYZDCMZVGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Requested changes made

[gregcorbett]

LGTM