Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter 0.9 api events bug #8630

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Conversation

wangyelei
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 15 lines in your changes missing coverage. Please review.

Project coverage is 64.67%. Comparing base (9e26c53) to head (70c7172).
Report is 2 commits behind head on release-0.9.

Files with missing lines Patch % Lines
pkg/controller/kubebuilderx/plan_builder.go 62.50% 4 Missing and 2 partials ⚠️
controllers/apps/componentdefinition_controller.go 0.00% 2 Missing and 1 partial ⚠️
controllers/apps/opsrequest_controller.go 0.00% 1 Missing and 1 partial ⚠️
...g/controller/instanceset/reconciler_api_version.go 33.33% 1 Missing and 1 partial ⚠️
controllers/apps/transformer_cluster_init.go 50.00% 1 Missing ⚠️
controllers/apps/transformer_component_init.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8630      +/-   ##
===============================================
- Coverage        64.80%   64.67%   -0.14%     
===============================================
  Files              359      359              
  Lines            45900    45920      +20     
===============================================
- Hits             29746    29697      -49     
- Misses           13500    13558      +58     
- Partials          2654     2665      +11     
Flag Coverage Δ
unittests 64.67% <44.44%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Dec 13, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Dec 13, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Dec 13, 2024
@wangyelei wangyelei merged commit b5981d1 into release-0.9 Dec 13, 2024
35 of 37 checks passed
@wangyelei wangyelei deleted the bugfix/filter-event-bug branch December 13, 2024 06:25
@github-actions github-actions bot added this to the Release 0.9.2 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants