Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the built-in function for generating ssh keys #8545

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

leon-inf
Copy link
Contributor

No description provided.

@leon-inf leon-inf added this to the Release 1.0.0 milestone Nov 28, 2024
@leon-inf leon-inf requested a review from a team as a code owner November 28, 2024 09:11
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.11%. Comparing base (61eb47e) to head (0c70dfc).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8545      +/-   ##
==========================================
+ Coverage   60.75%   61.11%   +0.35%     
==========================================
  Files         376      375       -1     
  Lines       45506    46163     +657     
==========================================
+ Hits        27648    28211     +563     
- Misses      15291    15364      +73     
- Partials     2567     2588      +21     
Flag Coverage Δ
unittests 61.11% <ø> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 29, 2024
@leon-inf leon-inf merged commit 9a5bfa9 into main Nov 29, 2024
39 checks passed
@leon-inf leon-inf deleted the support/remove-ssh-key-generation branch November 29, 2024 08:13
@leon-inf
Copy link
Contributor Author

/cherry-pick release-1.0-beta

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12081223148

github-actions bot pushed a commit that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants