Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: some reconciliation trace related corner cases fixed #8543

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Nov 28, 2024

No description provided.

@free6om free6om added this to the Release 1.0.0 milestone Nov 28, 2024
@free6om free6om self-assigned this Nov 28, 2024
@free6om free6om requested a review from a team as a code owner November 28, 2024 03:21
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Nov 28, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 28, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Nov 28, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 28, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Nov 28, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 30.30303% with 23 lines in your changes missing coverage. Please review.

Project coverage is 60.99%. Comparing base (08cc808) to head (08c81d7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
controllers/trace/informer_manager.go 0.00% 13 Missing ⚠️
pkg/controller/kubebuilderx/plan_builder.go 62.50% 4 Missing and 2 partials ⚠️
controllers/trace/resources_validator.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8543      +/-   ##
==========================================
+ Coverage   60.57%   60.99%   +0.42%     
==========================================
  Files         376      376              
  Lines       45478    45517      +39     
==========================================
+ Hits        27547    27762     +215     
+ Misses      15365    15195     -170     
+ Partials     2566     2560       -6     
Flag Coverage Δ
unittests 60.99% <30.30%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@free6om free6om merged commit 61eb47e into main Nov 28, 2024
35 checks passed
@free6om free6om deleted the support/reconciliation-trace-corner-cases-fix branch November 28, 2024 06:34
@free6om
Copy link
Contributor Author

free6om commented Nov 28, 2024

/cherry-pick release-1.0-beta

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12063755249

github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants