Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preConditionDeadlineSeconds of the opsRequest is invalid when creating some opsRequests together (pick from c65ed8c3) #8541

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Nov 27, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 27, 2024
@wangyelei wangyelei merged commit 6d24aca into release-0.9 Nov 27, 2024
34 of 37 checks passed
@wangyelei wangyelei deleted the bugfix/precondition_seconds branch November 27, 2024 09:45
@github-actions github-actions bot added this to the Release 0.9.2 milestone Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 58.22785% with 33 lines in your changes missing coverage. Please review.

Project coverage is 64.93%. Comparing base (f27e82f) to head (7128f0f).
Report is 3 commits behind head on release-0.9.

Files with missing lines Patch % Lines
controllers/apps/operations/ops_manager.go 69.56% 10 Missing and 4 partials ⚠️
controllers/apps/operations/ops_util.go 31.57% 11 Missing and 2 partials ⚠️
apis/apps/v1alpha1/opsrequest_webhook.go 57.14% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8541      +/-   ##
===============================================
+ Coverage        64.88%   64.93%   +0.05%     
===============================================
  Files              358      358              
  Lines            45659    45731      +72     
===============================================
+ Hits             29626    29697      +71     
- Misses           13391    13402      +11     
+ Partials          2642     2632      -10     
Flag Coverage Δ
unittests 64.93% <58.22%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants