Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dependency on sigs.k8s.io/kustomize/api/image (#8529) #8540

Merged

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Nov 27, 2024

No description provided.

@free6om free6om added this to the Release 0.9.2 milestone Nov 27, 2024
@free6om free6om self-assigned this Nov 27, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Nov 27, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 72.97297% with 10 lines in your changes missing coverage. Please review.

Project coverage is 65.03%. Comparing base (f27e82f) to head (5920eeb).
Report is 1 commits behind head on release-0.9.

Files with missing lines Patch % Lines
pkg/controller/instanceset/instance_util.go 72.97% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8540      +/-   ##
===============================================
+ Coverage        64.88%   65.03%   +0.15%     
===============================================
  Files              358      358              
  Lines            45659    45694      +35     
===============================================
+ Hits             29626    29719      +93     
+ Misses           13391    13346      -45     
+ Partials          2642     2629      -13     
Flag Coverage Δ
unittests 65.03% <72.97%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@free6om free6om merged commit 90f51c4 into release-0.9 Nov 27, 2024
39 checks passed
@free6om free6om deleted the support/remove-dependency-on-kustomize-api-image-0.9 branch November 27, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants