feat: move shell2http image to kb repository #8539
Conversation
|
|
stocrkc
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8539 +/- ##
==========================================
- Coverage 60.75% 60.67% -0.08%
==========================================
Files 376 376
Lines 45506 45506
==========================================
- Hits 27648 27613 -35
- Misses 15291 15334 +43
+ Partials 2567 2559 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stocrkc
force-pushed
the
feature/move-shell2http-image-to-kb
branch
from
38ba6c7
to
797543a
Compare
github-actions
bot
added
size/XS
stocrkc
force-pushed
the
feature/move-shell2http-image-to-kb
branch
from
797543a
to
52dabdb
Compare
stocrkc
force-pushed
the
feature/move-shell2http-image-to-kb
branch
from
52dabdb
to
9d41b33
Compare
| @@ -254,7 +254,7 @@ func injectCustomRoleProbeContainer(its *workloads.InstanceSet, template *corev1 | |||
| agentPath := strings.Join([]string{roleAgentVolumeMountPath, roleAgentName}, "/") | |||
| initContainer := corev1.Container{ | |||
| Name: roleAgentInstallerName, | |||
| Image: shell2httpImage, | |||
| Image: strings.Join([]string{viper.GetString(constant.KBImageRegistry), shell2httpImage}, "/"), | |||
There was a problem hiding this comment.
Should change shell2httpImage to "apecloud/shell2http:1.16.0"? Because the original repository "msoap" is not under our control. @free6om
There was a problem hiding this comment.
It's not like that, the whole path is like "docker.io/msoap/shell2http:1.16.0" or "apecloud-registry.cn-zhangjiakou.cr.aliyuncs.com/msoap/shell2http:1.16.0".
|
Seems #8018 can cover this use case. |
This should help fix #7720