Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the component controller is not notified upon restore completion #8535

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: the component controller is not notified upon restore completion #8535

merged 1 commit into from
Nov 27, 2024

Conversation

leon-inf
Copy link
Contributor

No description provided.

@leon-inf leon-inf requested review from Y-Rookie and a team as code owners November 27, 2024 01:47
@leon-inf leon-inf linked an issue Nov 27, 2024 that may be closed by this pull request
[BUG] Restore, CMP got stuck #8534
Closed
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 27, 2024
@leon-inf leon-inf added this to the Release 1.0.0 milestone Nov 27, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.35%. Comparing base (67c8856) to head (742656d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
controllers/apps/component_controller.go 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8535      +/-   ##
==========================================
+ Coverage   60.62%   61.35%   +0.72%     
==========================================
  Files         376      376              
  Lines       45405    45749     +344     
==========================================
+ Hits        27528    28069     +541     
+ Misses      15329    15122     -207     
- Partials     2548     2558      +10
Flag Coverage Δ
unittests 61.35% <50.00%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 27, 2024
@leon-inf
Copy link
Contributor Author

/approve

@leon-inf leon-inf merged commit cadccb3 into main Nov 27, 2024
37 checks passed
@leon-inf leon-inf deleted the bugfix/watch-restore-object branch November 27, 2024 04:20
@leon-inf
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@github-actions GitHub Actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12043679518

github-actions bot pushed a commit that referenced this pull request Nov 27, 2024
@leon-inf
fix: the component controller is not notified upon restore completion (…
de5f495 
…#8535)

(cherry picked from commit cadccb3)
@shanshanying shanshanying mentioned this pull request Nov 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apecloud-bot apecloud-bot apecloud-bot approved these changes

@zjx20 zjx20 zjx20 approved these changes

@Y-Rookie Y-Rookie Awaiting requested review from Y-Rookie Y-Rookie is a code owner

Assignees
No one assigned
Labels
approved PR Approved Test size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
Release 1.0.0
Development

Successfully merging this pull request may close these issues.

[BUG] Restore, CMP got stuck
3 participants
@leon-inf @zjx20 @apecloud-bot