fix: Check if the SQL is valid when creating a MySQL account. (#8611)

apecloud · Dec 9, 2024 · 2fc571f · 2fc571f
1 parent 94e8031
commit 2fc571f
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/lorry/engines/mysql/user.go b/pkg/lorry/engines/mysql/user.go
@@ -114,7 +114,11 @@ func (mgr *Manager) DescribeUser(ctx context.Context, userName string) (*models.
 	return user, nil
 }
 
-func (mgr *Manager) CreateUser(ctx context.Context, userName, password, _ string) error {
+func (mgr *Manager) CreateUser(ctx context.Context, userName, password, statement string) error {
+	if !strings.HasPrefix(statement, "CREATE ") {
+		return fmt.Errorf("the user %s is created with invalid sql %s, wait and try again", userName, statement)
+	}
+
 	sql := fmt.Sprintf(createUserSQL, userName, password)
 
 	_, err := mgr.Exec(ctx, sql)