Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIMA-6444] Automatically sign Eclipse plugins during release builds #281

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions uimaj-eclipse-maven-p2-site/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
<includeDependencies>false</includeDependencies>
<includeManaged>false</includeManaged>
<includeTransitiveDependencies>false</includeTransitiveDependencies>
<includePGPSignature>${tycho-include-gpg-signatures}</includePGPSignature>
</configuration>
</execution>
</executions>
Expand Down
25 changes: 25 additions & 0 deletions uimaj-eclipse-update-site/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@
<version>${tycho-version}</version>
<configuration>
<skipArchive>true</skipArchive>
<!--
Inclusion of GPG signatures not (yet?) supported
https://github.com/eclipse/tycho/discussions/946
-->
</configuration>
</plugin>
</plugins>
Expand All @@ -88,6 +92,10 @@
<exclude name="META-INF/**/*" />
</fileset>
</checksum>
<!--
This will clash with the tycho-gpg-plugin which also generates ASC files
for some of the artifacts
-->
<apply executable="gpg" dir="target/repository" failonerror="true">
<arg value="--detach-sign" />
<arg value="--armor" />
Expand All @@ -102,6 +110,23 @@
</execution>
</executions>
</plugin>
<!--
tycho-gpg-plugin 2.7.3 includes ALL public keys - not usable atm
https://github.com/eclipse/tycho/issues/948
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-gpg-plugin</artifactId>
<version>${tycho-version}</version>
<executions>
<execution>
<id>sign-p2-artifacts</id>
<goals>
<goal>sign-p2-artifacts</goal>
</goals>
</execution>
</executions>
</plugin>
-->
</plugins>
</build>
</profile>
Expand Down
10 changes: 10 additions & 0 deletions uimaj-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,8 @@
</pluginRepositories>

<properties>
<tycho-include-gpg-signatures>false</tycho-include-gpg-signatures>

<!--
Configuring settings is best done through default properties that multiple plugins.
Local configurations within plugins should be avoided. Where plugins do not pick up default
Expand Down Expand Up @@ -333,6 +335,14 @@
</build>

<profiles>
<profile>
<id>apache-release</id>

<properties>
<tycho-include-gpg-signatures>true</tycho-include-gpg-signatures>
</properties>
</profile>

<profile>
<id>jacoco</id>
<build>
Expand Down