Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters modal): layout cleanup, simplification, fixes #31448

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rusackas
Copy link
Member

SUMMARY

The new Add Filter/Divider buttons were getting hidden when the browser window was too short. "But it's flexbox, that shouldn't happen" I said. Then I started looking at all the onion layers of styled divs with random heights and overrides.

This PR cleans a bunch of junk up. There are fewer elements now, a few unnecessary overrides and styles are taken out, and things generally use more flexbox-native layouts. I could keep trimming until the cows come home, but I wanted to stop when the problem was fixed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Video demo with narration:
https://github.com/user-attachments/assets/1ebaab79-71bc-40e5-975e-d09b77bf75e6

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend dashboard:native-filters Related to the native filters of the Dashboard labels Dec 13, 2024
@sadpandajoe
Copy link
Member

/testenv up

Copy link
Contributor

@sadpandajoe Processing your ephemeral environment request here.

Copy link
Contributor

@sadpandajoe Ephemeral environment spinning up at http://54.190.59.231:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:frontend Requires changing the frontend dashboard:native-filters Related to the native filters of the Dashboard size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants