fix(filters modal): layout cleanup, simplification, fixes #31448
+61
−100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The new Add Filter/Divider buttons were getting hidden when the browser window was too short. "But it's flexbox, that shouldn't happen" I said. Then I started looking at all the onion layers of styled divs with random heights and overrides.
This PR cleans a bunch of junk up. There are fewer elements now, a few unnecessary overrides and styles are taken out, and things generally use more flexbox-native layouts. I could keep trimming until the cows come home, but I wanted to stop when the problem was fixed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Video demo with narration:
https://github.com/user-attachments/assets/1ebaab79-71bc-40e5-975e-d09b77bf75e6
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION