From e751eb223231130b0c544ff915f02a71db8fd479 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Wed, 11 Dec 2024 17:14:31 -0700 Subject: [PATCH] chore(ff): deprecating `DRILL_TO_DETAIL` feature flag to launch it into prime-time --- RESOURCES/FEATURE_FLAGS.md | 2 +- .../packages/superset-ui-core/src/utils/featureFlags.ts | 1 + superset/config.py | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index f985ad7254941..a09fb00b556bc 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -44,7 +44,6 @@ These features are **finished** but currently being tested. They are usable, but - ALLOW_FULL_CSV_EXPORT - CACHE_IMPERSONATION - CONFIRM_DASHBOARD_DIFF -- DRILL_TO_DETAIL - DYNAMIC_PLUGINS - ENABLE_SUPERSET_META_DB: [(docs)](https://superset.apache.org/docs/configuration/databases/#querying-across-databases) - ESTIMATE_QUERY_COST @@ -99,5 +98,6 @@ These features flags currently default to True and **will be removed in a future - AVOID_COLORS_COLLISION - DASHBOARD_CROSS_FILTERS +- DRILL_TO_DETAIL - ENABLE_JAVASCRIPT_CONTROLS - KV_STORE diff --git a/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts b/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts index be28944a9178d..e20d94c7d8549 100644 --- a/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts +++ b/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts @@ -36,6 +36,7 @@ export enum FeatureFlag { DashboardRbac = 'DASHBOARD_RBAC', DatapanelClosedByDefault = 'DATAPANEL_CLOSED_BY_DEFAULT', DisableLegacyDatasourceEditor = 'DISABLE_LEGACY_DATASOURCE_EDITOR', + /** @deprecated */ DrillToDetail = 'DRILL_TO_DETAIL', DrillBy = 'DRILL_BY', DynamicPlugins = 'DYNAMIC_PLUGINS', diff --git a/superset/config.py b/superset/config.py index 8a490a982d46d..b4c8f6422ce50 100644 --- a/superset/config.py +++ b/superset/config.py @@ -527,7 +527,7 @@ class D3TimeFormat(TypedDict, total=False): "CACHE_QUERY_BY_USER": False, # Enable sharing charts with embedding "EMBEDDABLE_CHARTS": True, - "DRILL_TO_DETAIL": True, + "DRILL_TO_DETAIL": True, # deprecated "DRILL_BY": True, "DATAPANEL_CLOSED_BY_DEFAULT": False, "HORIZONTAL_FILTER_BAR": False,