-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sqllab): giving the query history pane a facelift #31316
Conversation
@@ -384,6 +384,7 @@ export function runQueryFromSqlEditor( | |||
ctas, | |||
ctasMethod, | |||
) { | |||
console.log('YOYO', queryEditor); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log('YOYO', queryEditor); |
.catch(() => | ||
dispatch(addDangerToast(t('Failed at stopping query. %s', query.id))), | ||
); | ||
.catch(() => dispatch(addDangerToast(t('Failed at stopping query.')))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Failed to stop query"?
Fixing some styling and UI components in the query history pane in SQL Lab
7195636
to
700607d
Compare
Looks clean @mistercrunch! Two things from me me:
Thoughts? |
@kasiazjc -> screenshot based on latest tweaks Thinking a bit more about it, I'd like to create a standard way to represent timestamps/durations through a reusable react component. GPT-designer suggested this with a little clock which I think is kind of cute, but will make things more busy -> My issue with out current CRUD list/table views is that it looks very |
/testenv up |
@mistercrunch Processing your ephemeral environment request here. |
@mistercrunch Ephemeral environment spinning up at http://44.243.18.92:8080. Credentials are |
I think it looks more balanced with smaller icons and the pills for timestamp and duration look better too with it. Looks good for now and let's figure out crud enrichment/details next! |
@rusackas addressed the comments, probably mergeable as net positive |
LGTM! |
Fixing some styling and UI components in the query history pane in SQL Lab
before
after