Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(thumbnail cache): Enabling force parameter on screenshot/thumbnail cache #31757

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fisjac
Copy link
Contributor

@fisjac fisjac commented Jan 8, 2025

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Jan 8, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@github-actions github-actions bot added risk:db-migration PRs that require a DB migration api Related to the REST API doc Namespace | Anything related to documentation plugins dependencies:npm github_actions Pull requests that update GitHub Actions code packages labels Jan 8, 2025
adding CacheScreenshotPayload state machine
@fisjac fisjac force-pushed the force-cache-screenshot branch from f05f59a to 5ac969c Compare January 8, 2025 22:22
@github-actions github-actions bot removed risk:db-migration PRs that require a DB migration doc Namespace | Anything related to documentation plugins dependencies:npm github_actions Pull requests that update GitHub Actions code packages labels Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 27.55906% with 92 lines in your changes missing coverage. Please review.

Project coverage is 65.31%. Comparing base (76d897e) to head (5ac969c).
Report is 1294 commits behind head on master.

Files with missing lines Patch % Lines
superset/utils/screenshots.py 33.33% 48 Missing ⚠️
superset/charts/api.py 7.40% 25 Missing ⚠️
superset/dashboards/api.py 9.52% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #31757      +/-   ##
==========================================
+ Coverage   60.48%   65.31%   +4.82%     
==========================================
  Files        1931      538    -1393     
  Lines       76236    39202   -37034     
  Branches     8568        0    -8568     
==========================================
- Hits        46114    25606   -20508     
+ Misses      28017    13596   -14421     
+ Partials     2105        0    -2105     
Flag Coverage Δ
hive 48.74% <27.55%> (-0.42%) ⬇️
javascript ?
presto 53.24% <27.55%> (-0.56%) ⬇️
python 65.31% <27.55%> (+1.83%) ⬆️
unit 60.87% <27.55%> (+3.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the REST API review:draft size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants