Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CronPicker dropdowns don't render on alert&report modals #31755

Open
3 tasks done
msyavuz opened this issue Jan 8, 2025 · 4 comments
Open
3 tasks done

CronPicker dropdowns don't render on alert&report modals #31755

msyavuz opened this issue Jan 8, 2025 · 4 comments
Assignees
Labels
alert-reports Namespace | Anything related to the Alert & Reports feature

Comments

@msyavuz
Copy link
Contributor

msyavuz commented Jan 8, 2025

Bug description

  1. Go to Alerts&Reports
  2. Click add alert button
  3. Go to schedule tab and try to change schedule

Screenshots/recordings

image

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Firefox

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
Copy link

dosubot bot commented Jan 8, 2025

The issue with the CronPicker dropdowns not rendering in the Alerts&Reports scheduling UI could be related to how the component is integrated or styled, especially since it's occurring in Firefox. The CronPicker component is used in the AlertReportCronScheduler component when the scheduleFormat is set to ScheduleType.Picker [1].

Here are a few things you might want to check or try:

  1. CSS and Styling: Ensure that the CSS styles applied to the CronPicker are compatible with Firefox. The component uses Ant Design's ConfigProvider and custom styles, which might behave differently in Firefox [2].

  2. JavaScript Console: Check the browser's console for any JavaScript errors or warnings that might indicate why the dropdowns are not rendering.

  3. Dependencies: Verify that all dependencies, especially those related to dropdowns like rc-dropdown and react-js-cron, are correctly installed and up to date [3].

  4. Browser Compatibility: Consider testing the component in other browsers to see if the issue is specific to Firefox. This might help narrow down the problem to a browser-specific compatibility issue.

If these steps don't resolve the issue, further investigation into the specific styles or scripts that might be causing the problem in Firefox would be necessary.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@dosubot dosubot bot added the alert-reports Namespace | Anything related to the Alert & Reports feature label Jan 8, 2025
@msyavuz msyavuz changed the title CronPicker dropdowns don't render CronPicker dropdowns don't render on alert&report modals Jan 8, 2025
@rusackas
Copy link
Member

rusackas commented Jan 8, 2025

That's... odd. Heads up to @eschutho and @sadpandajoe in case this is a new regression they want to keep an eye on.

@msyavuz
Copy link
Contributor Author

msyavuz commented Jan 9, 2025

I think its related to Modal as CronPicker works in storybook otherwise.

@alexandrusoare
Copy link
Contributor

I worked on the Modal upgrade, I would like to fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert-reports Namespace | Anything related to the Alert & Reports feature
Projects
None yet
Development

No branches or pull requests

3 participants