Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(legacy-plugin-chart-map-box / legacy-preset-deckgl): Bump react-map-gl to v7 #31200

Closed
wants to merge 2 commits into from

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Dec 1, 2024

Part of #30307

Upgrading the react-map-gl to v7, which is agnostic for maplibre/mapbox
Bumping the web-mercator of deckgl preset, so it's the same version as mapbox plugin.

@pull-request-size pull-request-size bot added size/L and removed size/S labels Dec 1, 2024
@birkskyum birkskyum marked this pull request as draft December 1, 2024 05:13
@birkskyum birkskyum closed this Dec 1, 2024
@rusackas
Copy link
Member

rusackas commented Dec 5, 2024

Thanks for taking this on.... is there still hope? 🤞

@augusttown
Copy link

@birkskyum I am very interested in this temporary solution before fully migrating to MapLibre. Do I understand correctly that once this is merged then I can choose to use maplibre as underneath lib in react-map-gl to display the map and if at the same time I use maptiler tiles service then I am cleanly cut off from the MapBox right?

I saw this PR is closed, do you know when this can be merged into master?

@augusttown
Copy link

At the same time, is it possible to build a Superset docker with this upgrade change and use it local for testing purpose?

@augusttown
Copy link

Thanks for taking this on.... is there still hope? 🤞

@rusackas do you know the status of this pull request? Is it ready to be merged? I am trying to run the build on top of this feature branch but getting dependencies error as below

2025-01-08 19:57:22 npm error Found: [email protected]
2025-01-08 19:57:22 npm error node_modules/react
2025-01-08 19:57:22 npm error react@"^16.13.1" from the root project
2025-01-08 19:57:22 npm error
2025-01-08 19:57:22 npm error Could not resolve dependency:
2025-01-08 19:57:22 npm error peer react@"^17.0.0 || ^18.0.0 || ^19.0.0" from [email protected]
2025-01-08 19:57:22 npm error node_modules/react-intersection-observer
2025-01-08 19:57:22 npm error react-intersection-observer@"^9.10.2" from the root project
2025-01-08 19:57:22 npm error
2025-01-08 19:57:22 npm error Fix the upstream dependency conflict, or retry
2025-01-08 19:57:22 npm error this command with --force or --legacy-peer-deps
2025-01-08 19:57:22 npm error to accept an incorrect (and potentially broken) dependency resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants