-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: keep the tab order #30888
base: master
Are you sure you want to change the base?
fix: keep the tab order #30888
Conversation
FYI @yousoph |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30888 +/- ##
===========================================
+ Coverage 0 83.77% +83.77%
===========================================
Files 0 538 +538
Lines 0 39152 +39152
===========================================
+ Hits 0 32799 +32799
- Misses 0 6353 +6353
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LGTM, but @eschutho might be better poised to actually test this before approving/merging. |
response_data = json.dumps({"result": result}) | ||
return Response( | ||
response_data, status=HTTPStatus.OK, mimetype="application/json" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUMMARY
When export all tabs to a PDF in report & alert, user noticed that the all tabs export doesn't seem to export the tabs in any specific order (our report with 3 tabs exported with tab 2, then 3, then 1 in the PDF)
reference: #30694 (comment)
Context
The exported tabs are now ordered based on the sequence of anchors under the all_tabs field from the tabs endpoint response. This enhancement aligns the export order with the order displayed on the dashboard.
BEFORE PDF
before.pdf
AFTER PDF
after.pdf
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION