Feature configuration to modify storage credential lifetime #408
+85
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-maynard
requested review from
jbonofre,
ashvina,
RussellSpitzer,
snazy,
vvcephei,
takidau,
jackye1995,
flyrain,
collado-mike and
ebyhr
as code owners
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCache.java
Outdated
Show resolved
Hide resolved
10 tasks
lrichards-etsy
approved these changes
Nov 12, 2024
flyrain
approved these changes
Dec 20, 2024
| * Returns the value of a `PolarisConfiguration`, or the default if it cannot be loaded. This | ||
| * method does not need to be used when a `CallContext` is already available | ||
| */ | ||
| public static <T> T loadConfig(PolarisConfiguration<T> configuration) { |
There was a problem hiding this comment.
+1 on this method. There are a lot of other places can reuse this as well, like here https://github.com/polaris-catalog/polaris/blob/main/polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java#L1029-L1029. We can consolidate them in a followup PR.
Comment on lines
+74
to
+76
| .durationSeconds( | ||
| PolarisConfiguration.loadConfig( | ||
| PolarisConfiguration.STORAGE_CREDENTIAL_DURATION_SECONDS)) |
There was a problem hiding this comment.
Minor suggestion: we could keep them in one line like the following if we import the static field/method.
.durationSeconds(loadConfig(STORAGE_CREDENTIAL_DURATION_SECONDS))
Comment on lines
+230
to
+232
| .description( | ||
| "The duration of time that vended storage credentials are valid for. Support for" | ||
| + " longer (or shorter) durations is dependent on the storage provider.") |
There was a problem hiding this comment.
Minor suggestion: adding a comment that GCS isn't supported yet?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If users want to extend/shorten the lifetime of vended storage credentials, we can support that with a
PolarisConfiguration.I didn't see a way to implement this for
GcpStorageIntegration, so that is notably missing from this PR for now.Type of change