Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To allow ProxyManager return null (or empty proxy) for not using a proxy for some specific requests #1246

Open
1 of 3 tasks
chhsiao90 opened this issue Jul 5, 2024 · 2 comments

Comments

@chhsiao90
Copy link
Contributor

What kind of issue is this?

  • Question. This issue tracker is not the best place for questions. If you want to ask how to do
    something, or to understand why something isn't working the way you expect it to, use StackOverflow
    instead with the label 'stormcrawler': https://stackoverflow.com/questions/tagged/stormcrawler

  • Bug report. If you’ve found a bug, please include a test if you can, it makes it a lot easier to fix things. Use the label 'bug' on the issue.

  • Feature request. Please use the label 'wish' on the issue.

In our use case, we have our own ProxyManager implementation, we'd like to have the flexibility to use proxies for some requests, but no proxy for other cases.

@chhsiao90
Copy link
Contributor Author

I'd like to create a PR for this.

@jnioche
Copy link
Contributor

jnioche commented Jul 5, 2024

Yes please.
ProxyManager could return an Optional depending on the Metadata. The code in the protocol implementations would need changing accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants