Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Successfully Compiled PS on Aarch64 Raspberry Pi. How to contribute my binary? #1745

Open
Danrancan opened this issue Feb 15, 2022 · 4 comments

Comments

@Danrancan
Copy link

After reading through some github posts and documentation, it seems pagespeed doesn't really support ARM. However, with the help of developer Gusco on Gitlab, I have successfully compiled the pagespeed module for the Raspberry Pi 3 and Raspberry Pi 4 against nginx 1.21.6. Since I maintain a server, I will be compiling these modules with every update of nginx for the raspeberry pi on ubuntu server 20.04. I figure, as long as I am doing the work, I might as well upload the binaries somewhere for people to freely download. My question, is what is the correct procedure to uploading compiled binary releases of pagespeed and how can I prove (in the upload) that my work is trustworthy and compiled directly from source on a clean system? What exactly do I need to do to make this contribution towards the pagespeed and raspberry pi community?

Any advice and tips would be a great starting place for me. I am trying to become more involved in development processes. Thank you kindly!

Dan

@Lofesa
Copy link

Lofesa commented Feb 15, 2022

@oschaaf can you take a look?

@oschaaf
Copy link
Member

oschaaf commented Feb 15, 2022

Cool! I think ASF releases generally consist of source code, but they can offer packages & binaries as a courtesy.
See https://dlcdn.apache.org/incubator/pagespeed/1.14.36.1/

Ideally, we would work on reviewing & merging the required changes to support ARM, and test them in CI.
Following that we could amend the release process to incorporate the new artefacts.

@oschaaf
Copy link
Member

oschaaf commented Feb 15, 2022

Whoop - that went out too early.

In this case, I signed off on the release; to be able to do in a sensible way I met face to face with other ASF folks to cross sign my ASF release signing key:
https://dlcdn.apache.org/incubator/pagespeed/KEYS and through that become part of the "web of trust".
I'm not exactly sure how that works today, face to face meetings are much less common now.

In any case, there's multiple facets to this. If you are willing to put in the work and commit to maintaining the ARM stuff, I would be willing to help out with review and all, and I suspect others would too.

@Danrancan
Copy link
Author

Whoop - that went out too early.

In this case, I signed off on the release; to be able to do in a sensible way I met face to face with other ASF folks to cross sign my ASF release signing key: https://dlcdn.apache.org/incubator/pagespeed/KEYS and through that become part of the "web of trust". I'm not exactly sure how that works today, face to face meetings are much less common now.

In any case, there's multiple facets to this. If you are willing to put in the work and commit to maintaining the ARM stuff, I would be willing to help out with review and all, and I suspect others would too.

I would be willing to commit to maintaining the ARM stuff. However, after attempting to compile against Nginx 1.23.1 mainline, I am having compiles issues. I will make a separate post about it. Let me know what else I can do to proceed with this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants