Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-6588][CH] Cast columns if necessary before finally writing to ORC/Parquet files during native inserting #6691

Merged
merged 7 commits into from
Aug 4, 2024

Conversation

taiyang-li
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #6588)

Copy link

github-actions bot commented Aug 2, 2024

#6588

Copy link

github-actions bot commented Aug 2, 2024

Run Gluten Clickhouse CI

1 similar comment
Copy link

github-actions bot commented Aug 2, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 2, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 2, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 2, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 2, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 2, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Aug 4, 2024

Run Gluten Clickhouse CI

Copy link
Contributor

@baibaichen baibaichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baibaichen baibaichen merged commit 5d6c6f3 into apache:main Aug 4, 2024
8 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_08_04_2024_time.csv log/native_master_08_03_2024_cb0ad20244_time.csv difference percentage
q1 14.26 14.45 0.191 101.34%
q2 14.32 14.49 0.174 101.22%
q3 4.72 2.59 -2.135 54.81%
q4 68.76 70.09 1.328 101.93%
q5 9.05 9.56 0.508 105.62%
q6 3.88 2.48 -1.401 63.87%
q7 6.85 4.89 -1.962 71.37%
q8 3.41 5.20 1.792 152.53%
q9 26.01 24.08 -1.933 92.57%
q10 9.69 10.27 0.577 105.95%
q11 37.00 37.14 0.142 100.39%
q12 1.30 1.47 0.173 113.30%
q13 6.49 6.36 -0.133 97.96%
q14a 44.37 46.95 2.579 105.81%
q14b 41.54 42.04 0.501 101.21%
q15 2.50 2.58 0.078 103.14%
q16 44.99 45.65 0.663 101.47%
q17 4.67 5.14 0.473 110.13%
q18 6.85 6.57 -0.276 95.97%
q19 2.02 2.13 0.108 105.37%
q20 1.43 1.40 -0.033 97.68%
q21 1.16 2.35 1.191 202.37%
q22 7.53 7.61 0.075 101.00%
q23a 108.01 101.91 -6.102 94.35%
q23b 125.70 126.16 0.459 100.37%
q24a 99.16 99.15 -0.010 99.99%
q24b 96.89 100.18 3.295 103.40%
q25 4.08 4.24 0.166 104.07%
q26 3.48 3.23 -0.248 92.86%
q27 4.06 3.97 -0.097 97.60%
q28 32.57 32.88 0.312 100.96%
q29 10.83 10.43 -0.394 96.37%
q30 4.82 5.27 0.443 109.18%
q31 7.64 7.48 -0.153 97.99%
q32 1.21 1.18 -0.020 98.32%
q33 4.49 4.15 -0.331 92.62%
q34 3.99 4.05 0.057 101.44%
q35 8.47 7.83 -0.644 92.40%
q36 4.81 4.57 -0.237 95.07%
q37 4.48 4.58 0.099 102.20%
q38 14.73 13.64 -1.087 92.62%
q39a 3.40 3.06 -0.339 90.01%
q39b 2.79 3.14 0.355 112.73%
q40 3.76 3.79 0.032 100.86%
q41 0.59 0.68 0.095 116.07%
q42 0.87 0.93 0.065 107.52%
q43 4.19 4.57 0.381 109.09%
q44 10.00 10.04 0.041 100.41%
q45 3.14 3.17 0.032 101.02%
q46 3.85 3.67 -0.179 95.35%
q47 17.63 17.45 -0.178 98.99%
q48 5.27 5.12 -0.147 97.20%
q49 8.57 8.63 0.066 100.77%
q50 21.38 21.74 0.359 101.68%
q51 9.78 9.97 0.187 101.91%
q52 1.11 1.11 -0.003 99.71%
q53 2.33 2.53 0.204 108.77%
q54 4.02 4.11 0.091 102.26%
q55 1.01 0.99 -0.025 97.53%
q56 4.25 4.11 -0.135 96.81%
q57 10.19 10.71 0.522 105.12%
q58 2.29 2.41 0.120 105.23%
q59 10.71 10.59 -0.123 98.85%
q60 4.20 4.12 -0.074 98.24%
q61 4.16 3.96 -0.196 95.28%
q62 4.65 4.54 -0.103 97.79%
q63 2.44 2.40 -0.037 98.49%
q64 63.23 61.63 -1.599 97.47%
q65 17.97 19.15 1.184 106.59%
q66 5.52 3.91 -1.614 70.77%
q67 382.62 387.09 4.470 101.17%
q68 3.51 3.50 -0.013 99.63%
q69 5.01 4.65 -0.361 92.80%
q70 10.95 11.95 1.001 109.14%
q71 2.45 2.41 -0.039 98.39%
q72 221.76 219.08 -2.682 98.79%
q73 2.41 2.46 0.051 102.13%
q74 22.26 22.63 0.368 101.65%
q75 26.77 26.46 -0.310 98.84%
q76 11.17 11.08 -0.086 99.23%
q77 2.11 2.22 0.119 105.66%
q78 50.06 50.02 -0.038 99.92%
q79 3.85 3.93 0.089 102.30%
q80 12.37 12.24 -0.127 98.98%
q81 4.76 4.87 0.108 102.26%
q82 7.27 6.90 -0.363 95.00%
q83 1.64 1.71 0.077 104.68%
q84 3.01 3.09 0.074 102.45%
q85 8.35 8.15 -0.200 97.61%
q86 3.96 4.02 0.065 101.64%
q87 14.94 13.21 -1.732 88.41%
q88 21.60 21.73 0.125 100.58%
q89 3.66 3.70 0.034 100.92%
q90 3.45 3.47 0.019 100.55%
q91 2.31 2.51 0.196 108.47%
q92 1.30 1.26 -0.040 96.93%
q93 38.49 37.80 -0.685 98.22%
q94 24.85 24.44 -0.407 98.36%
q9 89.33 89.03 -0.295 99.67%
q5 2.54 2.72 0.179 107.04%
q96 17.32 17.44 0.121 100.70%
q97 1.98 1.95 -0.026 98.67%
q98 9.85 10.52 0.668 106.78%
q99 9.85 10.52 0.668 106.78%
total 2153.39 2150.92 -2.474 99.89%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_08_04_2024_time.csv log/native_master_08_03_2024_cb0ad20244_time.csv difference percentage
q1 39.25 40.26 1.008 102.57%
q2 30.10 29.86 -0.241 99.20%
q3 52.58 52.75 0.163 100.31%
q4 42.21 40.74 -1.476 96.50%
q5 102.69 104.63 1.943 101.89%
q6 10.99 11.31 0.327 102.97%
q7 115.40 118.41 3.000 102.60%
q8 114.62 115.54 0.919 100.80%
q9 168.35 168.75 0.396 100.24%
q10 66.65 63.97 -2.680 95.98%
q11 26.90 26.80 -0.099 99.63%
q12 29.36 28.44 -0.915 96.88%
q13 51.16 50.82 -0.343 99.33%
q14 26.10 26.03 -0.069 99.74%
q15 54.47 53.86 -0.611 98.88%
q16 19.27 18.38 -0.888 95.39%
q17 130.44 129.47 -0.969 99.26%
q18 198.19 199.83 1.636 100.83%
q19 26.31 28.40 2.090 107.95%
q20 41.42 41.08 -0.338 99.18%
q21 383.15 373.81 -9.342 97.56%
q22 15.33 15.79 0.462 103.01%
total 1744.94 1738.92 -6.025 99.65%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] Insert wrong result for struct field
4 participants