-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-6067][CH][MINOR][UT] Pass backends-clickhouse ut in Spark 3.5 #6623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run Gluten Clickhouse CI |
17 tasks
baibaichen
changed the title
[GLUTEN-6067][CH][MINOR][UT] Move tpch/tpcds parquet test tpch/tpcds package
[GLUTEN-6067][CH][MINOR][UT] Move tpch/tpcds parquet test to tpch/tpcds package
Jul 29, 2024
baibaichen
force-pushed
the
feature/tpc-TEST
branch
from
July 29, 2024 09:24
f35cfa9
to
488ac61
Compare
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
lgbo-ustc
previously approved these changes
Jul 30, 2024
taiyang-li
previously approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
baibaichen
force-pushed
the
feature/tpc-TEST
branch
from
July 30, 2024 15:29
1085bdc
to
dc44e74
Compare
Run Gluten Clickhouse CI |
baibaichen
force-pushed
the
feature/tpc-TEST
branch
from
July 30, 2024 17:09
dc44e74
to
2ff0fb5
Compare
Run Gluten Clickhouse CI |
baibaichen
force-pushed
the
feature/tpc-TEST
branch
from
July 31, 2024 02:24
2ff0fb5
to
12e2982
Compare
Run Gluten Clickhouse CI |
baibaichen
changed the title
[GLUTEN-6067][CH][MINOR][UT] Move tpch/tpcds parquet test to tpch/tpcds package
[GLUTEN-6067][CH][MINOR][UT] Pass backends-clickhouse ut in Spark 3.5
Jul 31, 2024
Run Gluten Clickhouse CI |
baibaichen
force-pushed
the
feature/tpc-TEST
branch
from
July 31, 2024 03:45
5e70f81
to
531a4c0
Compare
Run Gluten Clickhouse CI |
2. move tpcds ut to tpcds package 3. pass ut in spark 3.5
1. isSparkVersionGE("3.5") 2. isSparkVersionLE("3.3")
baibaichen
force-pushed
the
feature/tpc-TEST
branch
from
July 31, 2024 04:12
531a4c0
to
29f8756
Compare
Run Gluten Clickhouse CI |
binmahone
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move tpch/tpcds parquet test to tpch/tpcds package, so that we can run these tests in spark-3.5 ut
(Fixes: #6067)
How was this patch tested?
Using Existed UTs