-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-6067][CH][Minor] Compile Spark-3.5 ut with backends-clickhouse #6114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run Gluten Clickhouse CI |
17 tasks
CC @JkSelf, please help to take a look |
…ompile spark-ut with spark-3.5 profile
baibaichen
force-pushed
the
feature/spark_35_build
branch
from
June 17, 2024 09:58
5834910
to
5ca17fc
Compare
Run Gluten Clickhouse CI |
JkSelf
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
GlutenV1WriteCommandSuite
andGlutenInsertSuite
failed to compile with backends-clickhouse profiler. I refactor them in this PR, so we can compile spark-ut withspark-3.5
andbackends-clickhouse
profile. Once merged, we can add compile step in CICD asap to avoid regression.How to do
I introduce
GlutenColumnarWriteTestSupport
trait, and usebuild-helper-maven-plugin
to add diffierent implementation per backends(Fixes: #6067)
How was this patch tested?
Existed UTs