Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VL] Enable prefix sort in velox spill by config #7900

Open
jinchengchenghh opened this issue Nov 12, 2024 · 1 comment · May be fixed by #7904
Open

[VL] Enable prefix sort in velox spill by config #7900

jinchengchenghh opened this issue Nov 12, 2024 · 1 comment · May be fixed by #7904
Labels
enhancement New feature or request

Comments

@jinchengchenghh
Copy link
Contributor

Description

velox use config spill_enable_prefix_sort to control whether use prefix sort or timsort in spill.
Prefix sort requires extra memory for prefix data but gets 2x times acceleration. It does not support string and complex data type now, fallback to std::sort in that case.
@jinchengchenghh jinchengchenghh added the enhancement New feature or request label Nov 12, 2024
@jinchengchenghh jinchengchenghh changed the title Enable prefix sort in velox spill by config [VL] Enable prefix sort in velox spill by config Nov 12, 2024
@jinchengchenghh jinchengchenghh linked a pull request Nov 12, 2024 that will close this issue
Open
@FelixYBW
Copy link
Contributor

how much impact to Gluten spill performance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GLUTEN-7900][VL] Enable prefix sort in spill jinchengchenghh/gluten
2 participants
@FelixYBW @jinchengchenghh