From 2d473a28075a9766ae726b54ec696fe95c97ea7d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?JB=20Onofr=C3=A9?= Date: Wed, 17 Jan 2024 14:26:42 +0100 Subject: [PATCH] Build: Upgrade to Apache RAT 0.16, scanning hidden directories and adding missing ASF header --- .baseline/eclipse/dynamic/dotfile.checkstyle | 15 +++++++++++++++ .github/ISSUE_TEMPLATE/iceberg_bug_report.yml | 19 +++++++++++++++++++ .../ISSUE_TEMPLATE/iceberg_improvement.yml | 19 +++++++++++++++++++ .github/ISSUE_TEMPLATE/iceberg_question.yml | 19 +++++++++++++++++++ dev/.rat-excludes | 4 ++++ dev/check-license | 4 ++-- 6 files changed, 78 insertions(+), 2 deletions(-) diff --git a/.baseline/eclipse/dynamic/dotfile.checkstyle b/.baseline/eclipse/dynamic/dotfile.checkstyle index c176af2f34e3..7c3a5e04422d 100644 --- a/.baseline/eclipse/dynamic/dotfile.checkstyle +++ b/.baseline/eclipse/dynamic/dotfile.checkstyle @@ -1,5 +1,20 @@ + diff --git a/.github/ISSUE_TEMPLATE/iceberg_bug_report.yml b/.github/ISSUE_TEMPLATE/iceberg_bug_report.yml index 0e41cfb7c9a4..a4e939d2846d 100644 --- a/.github/ISSUE_TEMPLATE/iceberg_bug_report.yml +++ b/.github/ISSUE_TEMPLATE/iceberg_bug_report.yml @@ -1,3 +1,22 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + --- name: Iceberg Bug report 🐞 description: Problems, bugs and issues with Apache Iceberg diff --git a/.github/ISSUE_TEMPLATE/iceberg_improvement.yml b/.github/ISSUE_TEMPLATE/iceberg_improvement.yml index 9b7481ad8d07..d85a8f182135 100644 --- a/.github/ISSUE_TEMPLATE/iceberg_improvement.yml +++ b/.github/ISSUE_TEMPLATE/iceberg_improvement.yml @@ -1,3 +1,22 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + --- name: Iceberg Improvement / Feature Request description: New features with Apache Iceberg diff --git a/.github/ISSUE_TEMPLATE/iceberg_question.yml b/.github/ISSUE_TEMPLATE/iceberg_question.yml index cb827f4646be..25da32f4a874 100644 --- a/.github/ISSUE_TEMPLATE/iceberg_question.yml +++ b/.github/ISSUE_TEMPLATE/iceberg_question.yml @@ -1,3 +1,22 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + --- name: Iceberg Question description: Questions around Apache Iceberg diff --git a/dev/.rat-excludes b/dev/.rat-excludes index d41b7bb61e70..6dbaa6fccdc5 100644 --- a/dev/.rat-excludes +++ b/dev/.rat-excludes @@ -7,6 +7,9 @@ books.json new-books.json build .gitignore +.git +.gradle +.idea .rat-excludes LICENSE NOTICE @@ -24,6 +27,7 @@ gradle/* .*\.lock .*\.json .*\.bin +.*\.prefs package-list sitemap.xml derby.log diff --git a/dev/check-license b/dev/check-license index 93c528ab41e9..a236e6f5e966 100755 --- a/dev/check-license +++ b/dev/check-license @@ -58,7 +58,7 @@ else declare java_cmd=java fi -export RAT_VERSION=0.15 +export RAT_VERSION=0.16 export rat_jar="$FWDIR"/lib/apache-rat-${RAT_VERSION}.jar mkdir -p "$FWDIR"/lib @@ -68,7 +68,7 @@ mkdir -p "$FWDIR"/lib } mkdir -p build -$java_cmd -jar "$rat_jar" -E "$FWDIR"/dev/.rat-excludes -d "$FWDIR" > build/rat-results.txt +$java_cmd -jar "$rat_jar" --scan-hidden-directories -E "$FWDIR"/dev/.rat-excludes -d "$FWDIR" > build/rat-results.txt if [ $? -ne 0 ]; then echo "RAT exited abnormally"