Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Use CharSequenceMap for writing unordered deletes #9365

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

aokolnychyi
Copy link
Contributor

This PR migrates SortingPositionOnlyDeleteWriter to use CharSequenceMap to simplify the code. The new solution is essentially the same in terms of functionality and performance.

Before

Benchmark                                                                            Mode  Cnt  Score   Error  Units
ParquetWritersBenchmark.writeUnpartitionedClusteredPositionDeleteWriter                ss    5  1.682 ± 0.242   s/op
ParquetWritersBenchmark.writeUnpartitionedFanoutPositionDeleteWriter                   ss    5  2.949 ± 0.092   s/op
ParquetWritersBenchmark.writeUnpartitionedFanoutPositionDeleteWriterShuffled           ss    5  3.428 ± 0.089   s/op

After

Benchmark                                                                            Mode  Cnt  Score   Error  Units
ParquetWritersBenchmark.writeUnpartitionedClusteredPositionDeleteWriter                ss    5  1.608 ± 0.122   s/op
ParquetWritersBenchmark.writeUnpartitionedFanoutPositionDeleteWriter                   ss    5  2.998 ± 0.061   s/op
ParquetWritersBenchmark.writeUnpartitionedFanoutPositionDeleteWriterShuffled           ss    5  3.209 ± 0.480   s/op

@github-actions github-actions bot added the core label Dec 22, 2023
@aokolnychyi
Copy link
Contributor Author

@aokolnychyi aokolnychyi merged commit 6f4e33e into apache:main Dec 24, 2023
41 checks passed
@aokolnychyi
Copy link
Contributor Author

Thank you, @amogh-jahagirdar!

lisirrx pushed a commit to lisirrx/iceberg that referenced this pull request Jan 4, 2024
geruh pushed a commit to geruh/iceberg that referenced this pull request Jan 26, 2024
devangjhabakh pushed a commit to cdouglas/iceberg that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants