From 451b18b637c2a83d3f7103757478c026eb1822cb Mon Sep 17 00:00:00 2001 From: Bryan Keller Date: Wed, 7 Feb 2024 08:38:02 -0800 Subject: [PATCH] remove unneeded TODO comments --- .../java/org/apache/iceberg/connect/data/IcebergWriter.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java b/kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java index 591c1cb01058..8c8ef9e67332 100644 --- a/kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java +++ b/kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java @@ -57,7 +57,7 @@ private void initNewWriter() { @Override public void write(SinkRecord record) { try { - // TODO: config to handle tombstones instead of always ignoring? + // ignore tombstones... if (record.value() != null) { Record row = convertToRow(record); String cdcField = config.tablesCdcField(); @@ -111,8 +111,6 @@ private Operation extractCdcOperation(Object recordValue, String cdcField) { return Operation.INSERT; } - // TODO: define value mapping in config? - switch (opStr.charAt(0)) { case 'U': return Operation.UPDATE;