Reuse URIAuthority(Host) constructor avoiding creating new Host

instances Note: Host is immutable and therefore safe to pass on and reuse
apache · Oct 29, 2024 · dbb3cd4 · dbb3cd4
1 parent a510c68
commit dbb3cd4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/...2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2MultiplexingRequester.java b/...2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2MultiplexingRequester.java
@@ -177,7 +177,7 @@ private void execute(
             exchangeHandler.produceRequest((request, entityDetails, httpContext) -> {
                 final HttpHost host = target != null ? target : defaultTarget(request);
                 if (request.getAuthority() == null) {
-                    request.setAuthority(new URIAuthority(host.getHostName(), host.getPort()));
+                    request.setAuthority(new URIAuthority(host));
                 }
                 connPool.getSession(host, timeout, new FutureCallback<IOSession>() {
 

diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/HttpAsyncRequester.java b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/HttpAsyncRequester.java
@@ -292,7 +292,7 @@ public void execute(
             exchangeHandler.produceRequest((request, entityDetails, requestContext) -> {
                 final HttpHost host = target != null ? target : defaultTarget(request);
                 if (request.getAuthority() == null) {
-                    request.setAuthority(new URIAuthority(host.getHostName(), host.getPort()));
+                    request.setAuthority(new URIAuthority(host));
                 }
                 connect(host, timeout, null, new FutureCallback<AsyncClientEndpoint>() {
 

diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/HttpRequester.java b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/HttpRequester.java
@@ -332,7 +332,7 @@ public ClassicHttpResponse execute(
                 }
             }
             if (request.getAuthority() == null) {
-                request.setAuthority(new URIAuthority(targetHost.getHostName(), targetHost.getPort()));
+                request.setAuthority(new URIAuthority(targetHost));
             }
             final ClassicHttpResponse response = execute(connection, request, informationCallback, context);
             final HttpEntity entity = response.getEntity();