HTTPCLIENT-2318 - Enhance PoolingHttpClientConnectionManager with isShutdown State Check. #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arturobernalg Curiously enough I found this commit 6ba9b4a you contributed in the past. Could you please make sure all 3 conn manager implementations are consistent? |
arturobernalg
force-pushed
the
HTTPCLIENT-2318
branch
from
6821955
to
cc98eb7
Compare
@ok2c , absolutely. Thank you for pointing that out. |
ok2c
reviewed
Feb 22, 2024
| * @return {@code true} if the connection manager has been shut down and is closed, otherwise | ||
| * return {@code false}. | ||
| */ | ||
| boolean isClosed() { |
There was a problem hiding this comment.
@arturobernalg Should not the method be public?
There was a problem hiding this comment.
@arturobernalg Could you please add @since tags to the new public methods? Everything is OK otherwise.
arturobernalg
force-pushed
the
HTTPCLIENT-2318
branch
from
23c7aae
to
be0708f
Compare
…hutdown State Check. This commit introduces an `isShutdown` method to the `PoolingHttpClientConnectionManager` class, providing a thread-safe way to check whether the connection manager has been closed. The addition leverages an existing `AtomicBoolean` closed flag to ensure that the shutdown state can be queried reliably in concurrent environments.
arturobernalg
force-pushed
the
HTTPCLIENT-2318
branch
from
47fbbbf
to
cd37b8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue described in HTTPCLIENT-2318 by enhancing the
PoolingHttpClientConnectionManager. It introduces an isShutdown method for clear state checking and refines the close method for improved resource management, aiming to improve usability and reliability without affecting backward compatibility.