HTTPCLIENT-2290 - Refactor HttpClient synchronized sections for virtual threads #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturobernalg
changed the title
- Replaced `synchronized` blocks with `ReentrantLock` in `LeaseRequest` to better support virtual threads introduced in JDK 21. - Ensured each `LeaseRequest` instance has its own unique lock for maintaining original synchronization semantics. - Addressed potential performance and deadlock issues with virtual threads by using explicit lock primitives from `java.util.concurrent.locks`.
arturobernalg
force-pushed
the
HTTPCLIENT-2290
branch
from
0312bd4
to
ca7fb83
Compare
ok2c
approved these changes
Aug 26, 2023
ok2c
pushed a commit
that referenced
this pull request
Dec 13, 2023
- Replaced `synchronized` blocks with `ReentrantLock` in `LeaseRequest` to better support virtual threads introduced in JDK 21. - Ensured each `LeaseRequest` instance has its own unique lock for maintaining original synchronization semantics. - Addressed potential performance and deadlock issues with virtual threads by using explicit lock primitives from `java.util.concurrent.locks`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
synchronizedblocks withReentrantLockinLeaseRequestto better support virtual threads introduced in JDK 21.LeaseRequestinstance has its own unique lock for maintaining original synchronization semantics.java.util.concurrent.locks.