Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] SVG shadow width with lineStyle #20417

Open
Ovilia opened this issue Oct 14, 2024 · 3 comments
Open

[Bug] SVG shadow width with lineStyle #20417

Ovilia opened this issue Oct 14, 2024 · 3 comments
Labels
bug en This issue is in English SVG
Milestone

Comments

@Ovilia
Copy link
Contributor

Ovilia commented Oct 14, 2024

Version

5.5.1

Link to Minimal Reproduction

https://echarts.apache.org/examples/en/editor.html?c=line-smooth&version=5.5.1&renderer=svg&code=PYBwLglsB2AEC8sDeAoWsAeBBDEDOAXMmuqemAJ4gCmRA5AMYCGY1A5sAE4V0A0JAX37oKOfEVRlKNegDcmAGwCu1PoOGw81ThGqFYAbRLpJZWABMWTIgYCMvWPccOnrgHQAGL7YC6GqVS0sHQKENCq_qR4ABbAAO4AyhQAtgBGwApEAGaKWpHooeEJlApBpmZmcRDmYNFEACz5FbDMIPScwErQ5mrNZjFM5vEAwhlc9ADEWV69fVHRg_EAQsqcRACsTRUDQ3EA8llZWmAAGkS2Hlv9C7sHR9RgAJrnl8ZmQm8CJD4oAgDcQA

Steps to Reproduce

  1. Create a line series with data that's almost the same
  2. Set lineStyle.width to be 4
  3. Use SVG renderer to see the width of the line is not correct

Current Behavior

Line width is thinner than 4px when renderer is SVG but 4px when with Canvas.

Expected Behavior

Line width should be 4px, which is the same as canvas.

Environment

- OS:
- Browser:
- Framework:

Any additional comments?

No response

@Ovilia Ovilia added the bug label Oct 14, 2024
@echarts-bot echarts-bot bot added the en This issue is in English label Oct 14, 2024
@Ovilia Ovilia added SVG difficulty: easy Issues that can be fixed more easily than the average. labels Oct 14, 2024
@Ovilia Ovilia added this to the TBD milestone Oct 14, 2024
@Ovilia
Copy link
Contributor Author

Ovilia commented Oct 14, 2024

It seems that SVG don't render any shadow on elements with zero height and clips shadows with tiny height. So it may not easy to fix this problem.

@Ovilia Ovilia removed the difficulty: easy Issues that can be fixed more easily than the average. label Oct 14, 2024
@plainheart
Copy link
Member

Link to ecomfe/zrender#792

@Ovilia
Copy link
Contributor Author

Ovilia commented Oct 15, 2024

Link to ecomfe/zrender#792

Did this PR fix this problem? Can we merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug en This issue is in English SVG
Projects
None yet
Development

No branches or pull requests

2 participants