From 9e5c115f54e7040a0ee43b47729c62f13cddef4f Mon Sep 17 00:00:00 2001 From: James Turton Date: Wed, 16 Aug 2023 12:03:58 +0200 Subject: [PATCH 1/3] Shut down MiniDFS cluster in TestInboundImpersonation.selectChainedView. --- .../drill/exec/impersonation/TestInboundImpersonation.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java b/exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java index 18b1684a93a..3a2bc8e9077 100644 --- a/exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java +++ b/exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java @@ -92,6 +92,8 @@ public void selectChainedView() throws Exception { .go(); } adminClient.resetSystem(ExecConstants.IMPERSONATION_POLICIES_KEY); + } finally { + stopMiniDfsCluster(); } } From 77f8cb7d1fde8e1c203724ee791c0c475907ace8 Mon Sep 17 00:00:00 2001 From: James Turton Date: Wed, 16 Aug 2023 12:11:02 +0200 Subject: [PATCH 2/3] Ensure that MiniDFS is using simple auth in BaseTestImpersonation. --- .../drill/exec/impersonation/BaseTestImpersonation.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/BaseTestImpersonation.java b/exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/BaseTestImpersonation.java index f1d471d09e6..37ae508c37c 100644 --- a/exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/BaseTestImpersonation.java +++ b/exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/BaseTestImpersonation.java @@ -103,6 +103,13 @@ protected static void startMiniDfsCluster(String testClass, boolean isImpersonat // Set the proxyuser settings so that the user who is running the Drillbits/MiniDfs can impersonate other users. dfsConf.set(String.format("hadoop.proxyuser.%s.hosts", processUser), "*"); dfsConf.set(String.format("hadoop.proxyuser.%s.groups", processUser), "*"); + + // It isn't clear exactly when or why the following reinitialisation is + // needed, but without it the test subclasses of this class may crash + // when run in the GitHub CI with Mini DFS stating "Running in secure + // mode, but config doesn't have a keytab". + dfsConf.set("hadoop.security.authentication", "simple"); + UserGroupInformation.setConfiguration(dfsConf); } // Start the MiniDfs cluster From 1a52e708732967abdbb78aa0ad985fee65cc6fc5 Mon Sep 17 00:00:00 2001 From: James Turton Date: Wed, 16 Aug 2023 14:17:25 +0200 Subject: [PATCH 3/3] An empty commit to try to nudge the GitHub CI into action.