Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR UPDATE]: Fix Hadoop 3 impersonation test errors during CI runs #2822

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

jnturton
Copy link
Contributor

@jnturton jnturton commented Aug 16, 2023

[MINOR UPDATE]: Fix Hadoop 3 impersonation test errors during CI runs

Description

The following changes are made to resolve the "IO Running in secure mode, but config doesn't have a keytab" errors currently plaguing the Hadoop 3 impersonation tests when (and only when) they run in the GitHub CI [1].

  • Ensure that MiniDFS is using simple auth in BaseTestImpersonation.
  • Shut down MiniDFS cluster in TestInboundImpersonation.selectChainedView

These changes are sufficient to fix what I believe is a racy test harness set up / clean up bug that at this time only presents itself in the GitHub CI, and even then only with recent GitHub Runner images.

  1. Example: https://github.com/apache/drill/actions/runs/5867741986/job/15909061405

Documentation

N/A

Testing

CI runs.

@jnturton jnturton added bug ci CI backport-to-stable This bug fix is applicable to the latest stable release and should be considered for inclusion there labels Aug 16, 2023
@jnturton jnturton requested review from cgivre and vvysotskyi August 16, 2023 11:36
@jnturton jnturton self-assigned this Aug 16, 2023
@cgivre
Copy link
Contributor

cgivre commented Aug 16, 2023

Thanks for this. LGTM. +1

@jnturton jnturton changed the base branch from hadoop-impersonation-tests to master August 16, 2023 12:12
@jnturton
Copy link
Contributor Author

I'm not sure why the CI didn't kick off, perhaps because I had the wrong merge target branch set initially. I'll try to push up an empty commit to see if that gets it going.

Copy link
Contributor

@cgivre cgivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@jnturton jnturton merged commit 5c94c27 into apache:master Aug 16, 2023
cgivre pushed a commit to cgivre/drill that referenced this pull request Nov 2, 2023
…apache#2822)

* Shut down MiniDFS cluster in TestInboundImpersonation.selectChainedView.

* Ensure that MiniDFS is using simple auth in BaseTestImpersonation.
jnturton added a commit that referenced this pull request Dec 31, 2023
…#2822)

* Shut down MiniDFS cluster in TestInboundImpersonation.selectChainedView.

* Ensure that MiniDFS is using simple auth in BaseTestImpersonation.
jnturton added a commit to jnturton/drill that referenced this pull request Dec 31, 2023
…apache#2822)

* Shut down MiniDFS cluster in TestInboundImpersonation.selectChainedView.

* Ensure that MiniDFS is using simple auth in BaseTestImpersonation.
jnturton added a commit to jnturton/drill that referenced this pull request Jan 3, 2024
…apache#2822)

* Shut down MiniDFS cluster in TestInboundImpersonation.selectChainedView.

* Ensure that MiniDFS is using simple auth in BaseTestImpersonation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-stable This bug fix is applicable to the latest stable release and should be considered for inclusion there bug ci CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants