Fix BigQuery hyphenated ObjectName with numbers #1598
+61
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I messed up something while fixing clippy. I will fix. |
ayman-sigma
force-pushed
the
ayman/fixBigqueryHyphenatedObjectName
branch
from
acd682e to
0c01b33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently support hyphenated identifiers for BigQuery. The current code expects the number segment to be the last segment ex:
foo-123and should be followed by whitespace. That is true except when this identifier is part of an ObjectName. Ex:SELECT * FROM foo-123.bar.The issue is that tokenizer parse the previous string as:
[Word("foo"), Minus, Number("123."), Word("bar")]This PR:
foo-123.baras[Word('"foo"), Minus, Number("123"), Period, Word("bar")]foo-123.barasObjectName([Ident("foo-123"), Ident("bar")])instead of erroring out.