Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse INSERT with subquery when lacking column names #1586

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

iffyio
Copy link
Contributor

@iffyio iffyio commented Dec 11, 2024

Adds support to parse the example scenario:

INSERT INTO t1 (SELECT 1)

The parser previously looked to parse the subquery as a parenthesized list of column names which was
incorrect in this case.

Adds support to parse the example scenario:
```sql
INSERT INTO t1 (SELECT 1)
```

The parser previously looked to parse the subquery
as a parenthesized list of column names which was
incorrect in this case.
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iffyio

@alamb alamb merged commit 04271b0 into apache:main Dec 11, 2024
8 checks passed
@iffyio iffyio deleted the insert-subquery-wo-column-names branch December 12, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants