Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displaying WORK or TRANSACTION after BEGIN #1565

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

mvzink
Copy link
Contributor

@mvzink mvzink commented Nov 28, 2024

Fixes #1553

src/ast/mod.rs Outdated Show resolved Hide resolved
tests/sqlparser_sqlite.rs Show resolved Hide resolved
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mvzink

sqlite_and_generic().one_statement_parses_to("BEGIN DEFERRED", "BEGIN DEFERRED TRANSACTION");
sqlite_and_generic().one_statement_parses_to("BEGIN IMMEDIATE", "BEGIN IMMEDIATE TRANSACTION");
sqlite_and_generic().one_statement_parses_to("BEGIN EXCLUSIVE", "BEGIN EXCLUSIVE TRANSACTION");
sqlite_and_generic().verified_stmt("BEGIN DEFERRED");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alamb alamb merged commit c761f0b into apache:main Dec 4, 2024
8 checks passed
@alamb
Copy link
Contributor

alamb commented Dec 4, 2024

🚀

@mvzink mvzink deleted the fix-begin-transaction branch December 12, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BEGIN; is formatted as BEGIN TRANSACTION;, which is invalid in MySQL
3 participants