Support Databricks struct literal #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Nov 23, 2024
ayman-sigma
force-pushed
the
ayman/supportAsInDbStructs
branch
2 times, most recently
from
5bc791a to
3a252ad
Compare
iffyio
approved these changes
Nov 24, 2024
ayman-sigma
force-pushed
the
ayman/supportAsInDbStructs
branch
from
3a252ad to
5ca4524
Compare
ayman-sigma
force-pushed
the
ayman/supportAsInDbStructs
branch
from
5ca4524 to
fc553aa
Compare
|
Thanks @ayman-sigma and @iffyio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Databricks supports struct literal (struct function). Struct literal is already added for BigQuery. Databricks' syntax is very similar to the BigQuery one, except the fields definition part.
I added
supports_struct_literaltoDialecttrait to specify if the dialect support this literal or notDatabricks docs: https://docs.databricks.com/en/sql/language-manual/functions/struct.html