Add support for Snowflake SHOW DATABASES/SCHEMAS/TABLES/VIEWS/COLUMNS statements #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoavcloud
force-pushed
the
snowflake_show
branch
2 times, most recently
from
991298d to
85901b5
Compare
iffyio
reviewed
Nov 8, 2024
yoavcloud
force-pushed
the
snowflake_show
branch
from
85901b5 to
72a95c5
Compare
|
@iffyio thanks for the great comments, it really helped me improve this code. New commit for you to look at. |
iffyio
reviewed
Nov 10, 2024
There was a problem hiding this comment.
Left some comments, mostly small I think, the only one unclear to me was the mysql object_name insert behavior. I think this looks good overall, Thanks @yoavcloud!
iffyio
reviewed
Nov 12, 2024
src/dialect/mod.rs
Outdated
| @@ -606,6 +606,12 @@ pub trait Dialect: Debug + Any { | |||
| fn supports_top_before_distinct(&self) -> bool { | |||
| false | |||
| } | |||
|
|
|||
| /// Returns true if this dialect support the `LIKE 'pattern'` option in | |||
There was a problem hiding this comment.
Suggested change
| /// Returns true if this dialect support the `LIKE 'pattern'` option in | |
| /// Returns true if this dialect supports the `LIKE 'pattern'` option in |
iffyio
reviewed
Nov 12, 2024
iffyio
approved these changes
Nov 13, 2024
yoavcloud
force-pushed
the
snowflake_show
branch
from
b665ee3 to
c875757
Compare
|
🚀 |
|
Thanks again @iffyio and @yoavcloud |
|
We think this may have introduced a small regression: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the existing support for SHOW statements to Snowflake