-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164) #181
base: master
Are you sure you want to change the base?
Conversation
I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that. |
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation for default style. The behaviour was changed in iOS. I think it will be reasonable to do the same for this plugin. Also the default statusbar behaviour has became unavailable for iOS13 in master branch. This pull request fixes it. I think it Fixes #162 correctly as well. |
# Conflicts: # README.md
To me this makes more sense. Otherwise I have to implement app logic to set the right statusbar color and what makes this harder that there is no explicit dark style. |
Any update on this topic? When to expect a new official release with this PR merged? 🤔 |
Anyway we can help push this out? Really needed as it is probably the only pending use case when dealing with light and dark mode settings right now. |
I'm using @exxbrain PR master and it's working great on iOS. The behavior is opposite on Android when setting style using If I set the style using JS |
What's the current state on this issue? It's really important on iOS now. |
I'd like to get this PR merged, requesting some more eyes. I feel this is the cleaner approach, too. |
I think we should get a release as is and then do another release with this changes and also removing all the styles that don't work since iOS 7 (that has been deprecated for over a year in the plugin but not officially since it wasn't released) Not to mention that the PR has conflicts and the documentation is misleading since this is iOS 13+ only and that is not mentioned on the doc changes |
Any updates here? It pretty annoying that the statusbar text is white on a bright background in iOS :) |
I also have a problem with this. Can anyone complete the merge? |
I've also been having this issue, would love this to be merged asap! In the meantime @exxbrain's PR master works great but is a bit of out date, so I've merged it with the most up-to-date version of the current master. I've made my repo public here for anyone who needs it to save some time until this PR is merged or an alternative solution is made available. |
can this be merged to enable black text on light theme on dark mode? |
Another 👍🏻 for this patch. We have come across this as well... |
Platforms affected
All platforms, especially iOS.
Motivation and Context
Fixes #164. Fixes #162.
It has been already fixed but not completely correctly. iOS statusbar has different behaviour for Default and Dark styles.
Description
Added styleDarkContent similar to styleLightContent
Testing
Tested on iPhone SE with iOS 13, Android emulator SDK 29.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)