Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove potential error when setting exit code #640

Merged
merged 2 commits into from
Jun 15, 2024

Commits on May 20, 2024

  1. remove potential error setting exit code

    this commit implements a more reliable way of setting the CLI's exit code in error cases.
    
    Previously, I encountered this error when running the cli:
    ```console
    $ cordova build
    TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('ERR_UNHANDLED_ERROR')
        at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
        at /opt/nodejs/lib/node_modules/cordova/bin/cordova:33:22
    ```
    
    With this version, I get to see the root problem:
    ```console
    $ cordova build
    Unhandled error. ('Parsing /home/me/hello/config.xml failed')
    ```
    Molkars authored May 20, 2024
    Configuration menu
    Copy the full SHA
    dde3262 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Update cordova

    Molkars authored May 25, 2024
    Configuration menu
    Copy the full SHA
    fbf16da View commit details
    Browse the repository at this point in the history