Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove telemetry feature #633

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

shajz
Copy link
Contributor

@shajz shajz commented Dec 14, 2023

Platforms affected

n/a

Motivation and Context

Closes #625.

Telemetry relies on the insight package, which is unmaintained and relies on the request package which has a CVE GHSA-p8p7-x288-28g6

This is basically the same PR as #614 but it's now following this discussion with the backing of @breautek : #631 (comment)

Description

Remove the telemetry feature entirely

Testing

Ran npm run test successfully

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@shajz
Copy link
Contributor Author

shajz commented Dec 14, 2023

Haha @breautek, which PR do we keep? #632

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.53%. Comparing base (bf1f561) to head (46f9941).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
- Coverage   70.68%   65.53%   -5.16%     
==========================================
  Files           4        3       -1     
  Lines         307      235      -72     
==========================================
- Hits          217      154      -63     
+ Misses         90       81       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpogue
Copy link
Member

dpogue commented Jun 17, 2024

Hi @shajz, thanks for the PR! This one seems slightly more complete than #632 in that it also cleans up the documentation.

I'd really like to get this merged, if you have a chance to rebase it to resolve the conflicts on package.json. If you're busy, I can try to cherry-pick it onto a new branch next week and open a new PR retaining credit to you for the commit.

@dpogue dpogue mentioned this pull request Jun 17, 2024
5 tasks
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All test passes.

@shajz
Copy link
Contributor Author

shajz commented Jun 17, 2024

Hi @dpogue, I've rebased on master and fixed the conflicts on the package.json and package-lock.json files :)

I'll also mark the PR as ready for review, thanks for the interest in this PR!

@shajz shajz marked this pull request as ready for review June 17, 2024 17:13
@dpogue dpogue merged commit 71a5c89 into apache:master Jun 17, 2024
10 checks passed
@dpogue
Copy link
Member

dpogue commented Jun 17, 2024

Thank you @shajz! 🎉
Apologies for letting this sit open for so long.

@dpogue dpogue added this to the 13.0.0 milestone Jun 18, 2024
@shajz shajz deleted the feat.remove.telemetry branch July 1, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insight dependency with open CVE
4 participants