-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove telemetry feature #633
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #633 +/- ##
==========================================
- Coverage 70.68% 65.53% -5.16%
==========================================
Files 4 3 -1
Lines 307 235 -72
==========================================
- Hits 217 154 -63
+ Misses 90 81 -9 ☔ View full report in Codecov by Sentry. |
Hi @shajz, thanks for the PR! This one seems slightly more complete than #632 in that it also cleans up the documentation. I'd really like to get this merged, if you have a chance to rebase it to resolve the conflicts on package.json. If you're busy, I can try to cherry-pick it onto a new branch next week and open a new PR retaining credit to you for the commit. |
ef79cc4
to
46f9941
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All test passes.
Hi @dpogue, I've rebased on master and fixed the conflicts on the I'll also mark the PR as ready for review, thanks for the interest in this PR! |
Thank you @shajz! 🎉 |
Platforms affected
n/a
Motivation and Context
Closes #625.
Telemetry relies on the
insight
package, which is unmaintained and relies on therequest
package which has a CVE GHSA-p8p7-x288-28g6This is basically the same PR as #614 but it's now following this discussion with the backing of @breautek : #631 (comment)
Description
Remove the telemetry feature entirely
Testing
Ran
npm run test
successfullyChecklist
(platform)
if this change only applies to one platform (e.g.(android)
)