[Improvement] refactor krb5 avoid starting error in idea #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihadoop
changed the title
ihadoop
changed the title
zhoujinsong
reviewed
Dec 23, 2024
There was a problem hiding this comment.
@ihadoop Thanks to improve this implementation.
I left some comments, PTA:.
amoro-common/src/main/java/org/apache/amoro/table/TableMetaStore.java
Outdated
Show resolved
Hide resolved
…ig.refresh()' into refactor_-sun.security.krb5.Config.refresh()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3378.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation
reference https://github.com/zhengchenyu/incubator-uniffle/blob/2704aa33aa514441763e9efe284062f02aed2d25/common/src/test/java/org/apache/uniffle/common/KerberizedHadoop.java#L231