Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Support to stop/restart the optimizers when stop/restart the ams server #3328

Open
1 of 2 tasks
klion26 opened this issue Nov 12, 2024 · 6 comments · May be fixed by #3374
Open
1 of 2 tasks

[Feature]: Support to stop/restart the optimizers when stop/restart the ams server #3328

klion26 opened this issue Nov 12, 2024 · 6 comments · May be fixed by #3374
Labels
type:feature Feature Requests

Comments

@klion26
Copy link
Member

klion26 commented Nov 12, 2024

Description

Currently, the optimizers would not be stopped/restarted when the ams server stopped/restarted, but these are some scenarios which the optimizers need to be stopped/restarted such as we make an incompatible upgrade, or there are some critical bugs in the old version.

Use case/motivation

No response

Describe the solution

  1. stop the optimizers when the ams server stopped
  2. restart(stop + start with the new version) when restart the ams server

Subtasks

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@klion26 klion26 added the type:feature Feature Requests label Nov 12, 2024
@klion26
Copy link
Member Author

klion26 commented Nov 12, 2024

If anyone else is interested, please feel free to contribute. I will contribute to this if I find time(it's a little busy currently).

@ihadoop
Copy link
Contributor

ihadoop commented Dec 16, 2024

cool，can i try

@ihadoop
Copy link
Contributor

ihadoop commented Dec 16, 2024

i have question about stoping the optimizers when the ams server stopped. As i know,ams has ha, i assume when all ams server stopped then we can stop optimizers.

@klion26
Copy link
Member Author

klion26 commented Dec 17, 2024 •
edited
Loading

cool，can i try

@ihadoop Sure, please go ahead.

i have question about stoping the optimizers when the ams server stopped. As i know,ams has ha, i assume when all ams server stopped then we can stop optimizers.

from my side, the stop is here when the user calls ./bin/ams.sh stop, we can(with option) stop the optimizers also.

If you can share how to implement it before the code, it's better. thanks.

@ihadoop
Copy link
Contributor

ihadoop commented Dec 19, 2024

want to add stop-all.sh & start-all.sh

@ihadoop ihadoop linked a pull request Dec 19, 2024 that will close this issue
Open
3 tasks
@ihadoop
Copy link
Contributor

ihadoop commented Dec 19, 2024

@klion26 could you help to check？ if match you design， i will do more testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:feature Feature Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

restart & stop shell script ihadoop/amoro
2 participants
@klion26 @ihadoop